IntelliJ reacts to attribution enable/disable from site config #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkukielka
reviewed
Jan 19, 2024
src/main/java/com/sourcegraph/cody/agent/CurrentConfigFeatures.java
Outdated
Show resolved
Hide resolved
pkukielka
reviewed
Jan 19, 2024
pkukielka
reviewed
Jan 19, 2024
pkukielka
reviewed
Jan 19, 2024
|
All comments addressed, please take another look! This should be good to review now. |
cbart
changed the title
cbart
force-pushed
the
cb/59427/chat-attribution-ui-based-on-site-config
branch
from
b9ef3a7
to
623d90a
Compare
cbart
force-pushed
the
cb/59427/chat-attribution-ui-based-on-site-config
branch
from
623d90a
to
6ffbe11
Compare
pkukielka
reviewed
Jan 31, 2024
| * Given listener will be given new {@link ConfigFeatures} whenever they arrive. Observation | ||
| * relationship is ended once the returned cleanup {@link Runnable} is {@link Runnable#run()}. | ||
| */ | ||
| public Runnable attach(ConfigFeaturesObserver observer) { |
There was a problem hiding this comment.
Minor thing, but you could use CancellationToken here.
val cancellationToken = CancellationToken()
cancellationToken.onCancel { observers.remove(id) }
return cancellationTokenA bit more code but I think it is a bit more clear regarding the intent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes sourcegraph/sourcegraph#59427
This change adds
CurrentConfigFeaturessingleton/observer that allows the UI to react on whether attribution is turned on or off.Background:
TODO
Test plan